fix: handling side-effects for displaying external helm apps with same name across diff namespaces and clusters #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d) for external helm apps (in case same name ext helm app exists across diff ns or cluster)
prakash100198
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
|
PR is not linked to any issue, please make the corresponding changes in the body. |
… app identifier and if not found by unique app identifier, then find by display name
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10220829 | Triggered | Generic High Entropy Secret | ed1248f | charts/devtron/values.yaml | View secret |
| 10220829 | Triggered | Generic High Entropy Secret | ed1248f | charts/devtron/devtron-bom.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…to include also display_name
…ame as display name
…l while preparing helm package name deploymentContainer.HelmPackageName
…or UpdateApplicationWithChartInfo
…going to link a chart
…ion when going to link a chart
…stalledApp changed param to installed app id from appId which was wrong
# Conflicts: # api/helm-app/service/HelmAppService.go
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
# Conflicts: # pkg/app/AppCrudOperationService.go
…evtron with same name
nishant-d
approved these changes
May 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr handles the case when external helm apps with same name exists in diff namespaces and diff clusters, handling is done by storing display name, along with unique appName in app_name column of apps table ("displayName-ns-clusterId") for external helm apps (in case same name ext helm app exists across diff ns or cluster)
Fixes #4805
Checklist:
Does this PR introduce a user-facing change?