fix: apps and jobs permission #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kishan789dev
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
* grpc error handling * fix
* terminate operation before sync * using method for checking manual sync * terminating only in case of error * handling termination error * updating sync function
…5012) * fixed * code review comments
…4978) * introuddced api token versioning * fix * reverted wire_gen * migration udpated and minor refactor * refactor * moved const from apiToken pkg to user * reverted wire_gen * refactor * reverted wire_gen * concurrency case handled * fix * commented wherever necessary * refactor * fix * refactor * refactor * wip * refactor * added comments and minor refactor * refactor * refactoring * fix * added comments around cyclic import * added few more comments * sql script no updated
* introduction to feasibility * moved feasibility in trigger/devtronApps * feasibility refactorings * refactoring and feasibility manager * removing vulnerability changes * vulnerability checks retract * dry run removed * dry run checks removed * refactoring * removing unnecessary code * comments * trigger request
* Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes
* Update DockerfileEA * Update Dockerfile
* Changes made in the doc according to the newer version * Revert "Changes made in the doc according to the newer version" This reverts commit 1f4d806. * created a doc for the newer version of the plugin * added the pass/fail condition * corrected mistakes * added the new doc in the index file
…cronjob template charts (#5016) * handle for wrong format of k8s version in semvercompare func in cronjob template charts * TestStripPrereleaseFromK8sVersion UT's added * constants added * incorporated code review changes * merge main
* Add files via upload CD plugin * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 231_devtron_CD_trigger_v1.0.0.down.sql to 238_devtron_CD_trigger_v1.0.0.down.sql * Rename 231_devtron_CD_trigger_v1.0.0.up.sql to 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Update 238_devtron_CD_trigger_v1.0.0.up.sql * Rename 238_devtron_CD_trigger_v1.0.0.down.sql to 240_devtron_CD_trigger_v1.0.0.down.sql * Rename 238_devtron_CD_trigger_v1.0.0.up.sql to 240_devtron_CD_trigger_v1.0.0.up.sql --------- Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
* closing channel after write operation * removing close * using buffered channel * wip: making done channel bufferred * terminal racecondition and deadlock fix * wire run * removing done send call * updating bound channel send function
* git material flow added in transaction * wire refactored * code review comments incorporated * code review comments incorporated * code review comments incorporated
* wip * error handling done * fix --------- Co-authored-by: ayushmaheshwari <ayush@devtron.ai>
* feat: Plugin to trigger Devtron Job (#5052) * Update 241_devtronJobTrigger.up.sql
* handle context cancelled and deadline exceeded in fetch resource tree api * handle context cancelled and deadline exceeded error for resource tree fetch api for acd deployment * handle context cancelled and deadline exceeded error sync argo app with normal refresh * revert TIMEOUT_IN_SECONDS * revert bean TimeoutSlow param * fix
* cherry-pick * incorporating feedbacks
|
PR is not linked to any issue, please make the corresponding changes in the body. |
|
PR is not linked to any issue, please make the corresponding changes in the body. |
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
kartik-579
requested changes
May 22, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10190660 | Triggered | Generic Password | 8581fbe | tests/integrationTesting/devtron-secret.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Kishan789dev
changed the title
vikramdevtron
approved these changes
May 27, 2024
kartik-579
approved these changes
May 29, 2024
Kishan789dev
changed the title
Kishan789dev
changed the title
|
Kishan789dev
added a commit
that referenced
this pull request
May 30, 2024
This reverts commit 4b0e44d.
Kishan789dev
added a commit
that referenced
this pull request
May 30, 2024
Kishan789dev
added a commit
that referenced
this pull request
May 30, 2024
This reverts commit 4b0e44d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4846
Desription
fixed the issue related user permission ,user having permisssion for the view only was able to create app/job
Checklist:
-->