SAML Initiated Flow #3250
Open
SAML Initiated Flow #3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature rebases from the current master branch to include PR dexidp#1514.
nabokihms
requested changes
Dec 29, 2023
| @@ -14,6 +14,13 @@ message Client { | |||
| bool public = 5; | |||
| string name = 6; | |||
| string logo_url = 7; | |||
| SamlInitiatedConfig saml_initiated = 8; | |||
There was a problem hiding this comment.
Adding settings for a particular connector into generic structures is not good. Introducing a special handler for SAML is okay, but adding these options to ALL connectors could be better.
There was a problem hiding this comment.
What do you think is an alternative here?
Signed-off-by: Moustafa Amer <Moustafa.Amer@dw.com>
MostafaAmer2200
force-pushed
the
saml-initiated
branch
from
25c7bcf
to
c07adc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This was a requested feature in PR #1514. I've rebased the branch now everything should be up to date. In addition to some tests.
What this PR does / why we need it
This PR will allow users to authenticate using an IdP initiated flow. Before this feature, this only allows authentication through SP flow. This feature will allow to have both.
This addresses #1514 which was never merged since it became outdated. There seems to be a demand for this feature from four years ago and I hope this resolve. Happy to take any feedback to get this moving forward :)
Special notes for your reviewer