ESNext compatibility #812
Merged
ESNext compatibility #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed template literal to plain string, as not templating needed
all 239 tests passed on my machine with the prior commit (which would have been bypassed with the current if clause when running on a browser)
dfahlander
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Esnext change of removing Promise from global was new to me. I will need to read more about this. The code changes are trivial and as I understand it, by making sure Promise is put on global also in Esnext, the existing Dexie code will continue to work as before. Thanks for finding out a solution.
dfahlander
added a commit
that referenced
this pull request
Mar 22, 2019
Merged
dfahlander
added a commit
that referenced
this pull request
Mar 22, 2019
dfahlander
added a commit
that referenced
this pull request
Mar 25, 2019
typeof Promise is either "undefined" or "function". Also added some comments explaining why this statement is there. #812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will meet requirements for #811. It is in 2 commits (which I would advise squashing if you accept pull request). I ran all tests with the 1st commit, and all passed.
I think this is attaching the _global (ECMAScript) Promise high enough in the dependency chain that it is the native Promise implementation being added. I would assume if I was attaching the Dexie.promise at the wrong stage to the _global.Promise, the tests would fail after the 1st commit.
I also change template literal (back tick) to simple string as I think it is slightly more readable - I kept looking for the ${ insertion point, which wasn't there.
Thanks for creating this great library by the way.