Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dexie does not run under ESNext in Node #811

Closed
mcshaz opened this issue Mar 22, 2019 · 1 comment
Closed

Dexie does not run under ESNext in Node #811

mcshaz opened this issue Mar 22, 2019 · 1 comment

Comments

@mcshaz
Copy link
Contributor

mcshaz commented Mar 22, 2019 •
edited

in ESNext, Promise seems to be a first order object, and does not exist as a property of window or Node. As such, if looking at a project in TypeScript with ESNext & DOM type libraries, window.Promise causes an immediate syntax error which will not transpile. certainly, this code does not run under jsdom in ESNext in its current form.

My brief investigation of the spec leads me to believe that the ESNext DOM type libraries are correct in this implementation.

as per comments in #810, currently the Promise global will refer to the Dexie.Promise in the promise module.
@mcshaz mcshaz mentioned this issue Mar 22, 2019
Merged
@mcshaz
Copy link
Contributor Author

mcshaz commented Mar 29, 2019

thanks for fixing

@mcshaz mcshaz closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcshaz