Skip to content

Commit

Permalink
Delete example-kotlin (grpc#6936)
Browse files Browse the repository at this point in the history
  • Loading branch information
chalin authored and dfawley committed Jan 15, 2021
1 parent 1083408 commit 05f0516
Show file tree
Hide file tree
Showing 25 changed files with 1 addition and 880 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Expand Up @@ -28,7 +28,6 @@ install:
- pushd examples/example-hostname && ../gradlew build && popd
- pushd examples/example-hostname && mvn verify && popd
- pushd examples/example-tls && ../gradlew clean build && popd
- pushd examples/example-kotlin && ../gradlew build && popd
- pushd examples/example-xds && ../gradlew build && popd

before_script:
Expand Down
2 changes: 0 additions & 2 deletions RELEASING.md
Expand Up @@ -46,8 +46,6 @@ $ VERSION_FILES=(
examples/example-jwt-auth/pom.xml
examples/example-hostname/build.gradle
examples/example-hostname/pom.xml
examples/example-kotlin/build.gradle
examples/example-kotlin/android/helloworld/app/build.gradle
examples/example-tls/build.gradle
examples/example-tls/pom.xml
examples/example-xds/build.gradle
Expand Down
3 changes: 0 additions & 3 deletions buildscripts/kokoro/android.sh
Expand Up @@ -56,9 +56,6 @@ cd ../routeguide
cd ../helloworld
../../gradlew build

cd "$BASE_DIR/github/grpc-java/examples/example-kotlin/android/helloworld/"
../../../gradlew build

# Skip APK size and dex count comparisons for non-PR builds

if [[ -z "${KOKORO_GITHUB_PULL_REQUEST_COMMIT:-}" ]]; then
Expand Down
6 changes: 1 addition & 5 deletions examples/README.md
Expand Up @@ -158,10 +158,6 @@ $ bazel-bin/hello-world-client

- [JWT-based Authentication](example-jwt-auth)

- [Kotlin examples](example-kotlin)

- [Kotlin Android examples](example-kotlin/android)

## Unit test examples

Examples for unit testing gRPC clients and servers are located in [examples/src/test](src/test).
Expand All @@ -174,7 +170,7 @@ examples to write unit tests. `InProcessTransport` is light-weight and runs the
and client in the same process without any socket/TCP connection.

Mocking the client stub provides a false sense of security when writing tests. Mocking stubs and responses
allows for tests that don't map to reality, causing the tests to pass, but the system-under-test to fail.
allows for tests that don't map to reality, causing the tests to pass, but the system-under-test to fail.
The gRPC client library is complicated, and accurately reproducing that complexity with mocks is very hard.
You will be better off and write less code by using `InProcessTransport` instead.

Expand Down
62 changes: 0 additions & 62 deletions examples/example-kotlin/README.md

This file was deleted.

81 changes: 0 additions & 81 deletions examples/example-kotlin/android/helloworld/app/build.gradle

This file was deleted.

17 changes: 0 additions & 17 deletions examples/example-kotlin/android/helloworld/app/proguard-rules.pro

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 05f0516

Please sign in to comment.