Skip to content

Commit

Permalink
SECURITY.md: add instruction for disabling Conscrypt's default TrustM…
Browse files Browse the repository at this point in the history
…anager (grpc#6962)
  • Loading branch information
voidzcy authored and dfawley committed Jan 15, 2021
1 parent 627aaeb commit e23a445
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion SECURITY.md
Expand Up @@ -232,9 +232,14 @@ import java.security.Security;
...

// Somewhere in main()
Security.insertProviderAt(Conscrypt.newProvider(), 1);
Security.insertProviderAt(
Conscrypt.newProviderBuilder().provideTrustManager(false).build(), 1);
```

Note: according to [Conscrypt Implementation Notes](https://github.com/google/conscrypt/blob/2.4.0/IMPLEMENTATION_NOTES.md#hostname-verification),
its default `HostnameVerifier` on OpenJDK always fails. This can be worked
around by disabling its default `TrustManager` implementation as shown above.

### TLS with Jetty ALPN

**Please do not use Jetty ALPN**
Expand Down

0 comments on commit e23a445

Please sign in to comment.