Skip to content

Commit

Permalink
chore: aggregate test results for required statuses (#592)
Browse files Browse the repository at this point in the history
Status check names include matrix elements.  This means that required status names would have to change if any of those matrix elements changed in the future.

This change aggregates these checks into a single status check with a constant name, suitable for use as a required status.

Fixes https://dfinity.atlassian.net/browse/SDK-582
  • Loading branch information
ericswanson-dfinity committed Jul 12, 2022
1 parent 97f9352 commit 968530c
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/e2e-tests.yml
Expand Up @@ -47,3 +47,13 @@ jobs:
env:
CI: true
REPLICA_PORT: 8000

aggregate:
name: e2e:required
if: ${{ always() }}
needs: [ test ]
runs-on: ubuntu-latest
steps:
- name: check e2e test result
if: ${{ needs.test.result != 'success' }}
run: exit 1
10 changes: 10 additions & 0 deletions .github/workflows/mitm.yml
Expand Up @@ -63,3 +63,13 @@ jobs:
REPLICA_PORT: 8888
MITM: true
run: npm run mitm --workspaces --if-present

aggregate:
name: mitm:required
if: ${{ always() }}
needs: [ test ]
runs-on: ubuntu-latest
steps:
- name: check e2e test result
if: ${{ needs.test.result != 'success' }}
run: exit 1
10 changes: 10 additions & 0 deletions .github/workflows/prettier.yml
Expand Up @@ -28,3 +28,13 @@ jobs:
- run: npm install -g npm
- run: npm install prettier pretty-quick
- run: npm run prettier:check

aggregate:
name: format:required
if: ${{ always() }}
needs: [ test ]
runs-on: ubuntu-latest
steps:
- name: check e2e test result
if: ${{ needs.test.result != 'success' }}
run: exit 1
10 changes: 10 additions & 0 deletions .github/workflows/unit-tests.yml
Expand Up @@ -42,3 +42,13 @@ jobs:
- run: npm run test
env:
CI: true

aggregate:
name: unit:required
if: ${{ always() }}
needs: [ test ]
runs-on: ubuntu-latest
steps:
- name: check e2e test result
if: ${{ needs.test.result != 'success' }}
run: exit 1

0 comments on commit 968530c

Please sign in to comment.