feat: Use full IC Management IDL #406
Conversation
|
@megrogan I'd like to approve this - could you clean up the merge conflicts? |
# Conflicts: # packages/agent/src/canisters/management.ts # packages/agent/src/canisters/management_idl.ts
|
@krpeacock I have pushed 2 commits to my branch but seems like there is a github issue because the PR has not been updated. I will create a new PR. |
|
I think this was because my fork was still private whereas this repo has since become public. I have now made my fork public but the PR has not updated yet... |
|
This is my issue: I am following the 2nd answer and contacting github support... |
|
They have re-attached my fork |
|
What a weird state to get into! |
|
I just tried pushing another commit (just removed a full-stop from a comment!) and that seems to have finally wired it back up such that the other commits since my original one have now been applied to the PR too! |
|
Argh! Failing e2e tests. Will investigate |
|
@krpeacock Can we get this closed? I don't think this is being worked on. |
|
@megrogan I can't update your PR, but making this change to label the method as an https://github.com/dfinity/agent-js/blob/kyle/ic-management/e2e/node/basic/basic.test.ts#L50 |
|
That does raise a separate issue that we ought to figure out how to get |
* feat: Use full IC Management IDL * Assert fn prov...with_cycles has type ActorMethod Co-authored-by: Kyle Peacock <kylpeacock@gmail.com>
No description provided.