fix: Update webappsec types dependency #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzxchiang1
changed the title
|
Can someone rerun this? I don't know why it's failing. |
krpeacock
approved these changes
Mar 25, 2022
|
Yeah, the CI issue was unrelated. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, the
CredentialCreationOptionstype from this package is in the public interface of the@dfinity/identitypackage, so it should be part of the dependencies, not the devDependencies (because otherwise if it's part of the latter, like right now, it won't get transitively installed by users of@dfinity/identity, causing tsc errors for users).See these links for details: