fix: make makeNonce return unique random values #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The makeNonce method ended up returning the same value: 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
There were a couple problems:
The end result was that only the first byte of the nonce would have a nonzero value.
This change puts the current time in the high 64 bits (the first several bytes are still zero), and fills the low 64 bits with random data.
Fixes https://dfinity.atlassian.net/browse/SDK-396
How Has This Been Tested?
The first commit in this branch added a unit test, the failure of which demonstrates that the nonce values were not unique.
Checklist: