feat: support idle management in AuthClient #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the authClient to register actors to automatically invalidate them going idle, or revalidate them after logging in
krpeacock
force-pushed
the
SDK-307-support-invalidating-and-replacing-identities
branch
from
51be652
to
e826b43
Compare
|
I made the JS docs a little more verbose, but it does a better job of revealing the full API in intellisense |
https://github.com/dfinity/agent-js into SDK-307-support-invalidating-and-replacing-identities
krpeacock
changed the title
Allows the authClient to register actors to automatically invalidate them going idle, or revalidate them after logging in
https://github.com/dfinity/agent-js into SDK-307-support-invalidating-and-replacing-identities
dfx-json
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Nice work. The tests were clear and the code was easy to understand. I left one comment about whether this would ever need to be used in a nodejs environment - it wouldn't support that as-is clearly, but is environment compatibility something we should add to the README?
| func.apply(context, args); | ||
| }; | ||
| clearTimeout(timeout); | ||
| timeout = window.setTimeout(later, wait); |
There was a problem hiding this comment.
is auth-client ever meant to be used in a nodejs environment?
krpeacock
deleted the
SDK-307-support-invalidating-and-replacing-identities
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new IdleManager to detect when a user has gone idle, and calling callbacks
Fixes SDK-307
How Has This Been Tested?
Checklist: