Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn on bad origin #549

Merged
merged 2 commits into from Mar 30, 2022
Merged

feat: warn on bad origin #549

merged 2 commits into from Mar 30, 2022

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Mar 30, 2022

This adds a debug message in case II is replying with a bad origin.

@nmattia
feat: warn on bad origin
59de0d0 
This adds a debug message in case II is replying with a bad origin.
@nmattia nmattia requested a review from krpeacock March 30, 2022 16:42
krpeacock
krpeacock requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@krpeacock krpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can we just switch this to a console.warn? Otherwise looks good

packages/auth-client/src/index.ts Outdated Show resolved Hide resolved
@krpeacock krpeacock self-requested a review March 30, 2022 17:34
@nmattia nmattia merged commit bc098bf into main Mar 30, 2022
@nmattia nmattia deleted the nm-bad-origin branch March 30, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krpeacock krpeacock krpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nmattia @krpeacock