Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduces default delegation expiration to 8 hours #550

Merged
merged 5 commits into from Apr 1, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Mar 31, 2022

Description

Per security requests, reduces the default delegation expiration from 24 hours to 8.
Also cleans up and adds additional documentation

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from dfx-json March 31, 2022 00:00
@krpeacock krpeacock requested a review from a team March 31, 2022 00:01
Copy link
Contributor

@wackyleo459 wackyleo459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straight forward. I like how the user can create a specific idle timeout option. From my understanding, is the default idle timeout 30 minutes?

Also just wanted to point out there are several check annotation comments (under Beta), if you have not noticed before. Examples:
Screen Shot 2022-04-01 at 9 56 17 AM
Screen Shot 2022-04-01 at 9 56 50 AM

@krpeacock
Copy link
Contributor Author

Looks pretty straight forward. I like how the user can create a specific idle timeout option. From my understanding, is the default idle timeout 30 minutes?

It looks like that in the changes, but that's from example code. The default timeout is 10 minutes

Also just wanted to point out there are several check annotation comments (under Beta), if you have not noticed before. Examples: Screen Shot 2022-04-01 at 9 56 17 AM Screen Shot 2022-04-01 at 9 56 50 AM

Yeah, it's been like that for a while. Some low-priority cleanup that I can create tickets for

@krpeacock krpeacock merged commit d1b5e24 into main Apr 1, 2022
@krpeacock krpeacock deleted the SDK-329-1-day-timeout branch April 1, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants