Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add window config string #552

Merged
merged 4 commits into from Apr 7, 2022
Merged

feat: add window config string #552

merged 4 commits into from Apr 7, 2022

Conversation

plitzenberger
Copy link
Contributor

@plitzenberger plitzenberger commented Apr 6, 2022

Description

This extends the AuthClientLoginOptions interface to include a configuration string used to pass to the window.open function. Using this string allows the user to configure the opened II authentication window.

Tested by locally applying a sample configuration and updating the test suite:

Screenshot 2022-04-06 at 21 49 24

Checklist:

Guidance needed 馃檹

  • I have edited the CHANGELOG accordingly. (should I update the html?)
  • I have made corresponding changes to the documentation. (how can I update the docs?)

@plitzenberger plitzenberger changed the title Feat/add window config string feat: add window config string Apr 6, 2022
@krpeacock krpeacock merged commit 54de54d into dfinity:main Apr 7, 2022
@plitzenberger plitzenberger deleted the feat/add-window-config-string branch April 7, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants