Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes jest-expect message from toolchain #553

Merged
merged 2 commits into from Apr 6, 2022
Merged

fix: removes jest-expect message from toolchain #553

merged 2 commits into from Apr 6, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Apr 6, 2022 •
edited

Description

Test failures were producing a generic

result.message is not a function
TypeError: result.message is not a function

message instead of showing the expected vs received results.

By removing jest-expect-message, an unused piece of jest middleware, this issue is resolved

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team April 6, 2022 20:46
ericswanson-dfinity
ericswanson-dfinity approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@krpeacock krpeacock merged commit 5b544e8 into main Apr 6, 2022
@krpeacock krpeacock deleted the result-message-test-bug branch April 6, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @ericswanson-dfinity