Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate nonce for HttpAgent calls #554

Merged
merged 5 commits into from Apr 7, 2022
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Apr 6, 2022

Description

HttpAgent will now provide a unique nonce in calls to ensure that the replica treats each call as unique.

How Has This Been Tested?

Tested in our integration test suie

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock changed the title Sdk 390 generate nonce feat: generate nonce for HttpAgent calls Apr 6, 2022
@krpeacock krpeacock requested a review from a team April 6, 2022 22:49
@krpeacock krpeacock enabled auto-merge (squash) April 6, 2022 23:04
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at least one place that is still calling <agent>.addTransform(makeNonceTransform()): https://github.com/dfinity/agent-js/blob/main/demos/ledgerhq/src/main.js#L86

and a few that add a different nonce transform, but without specifying the disableNonce option.
Examples:

docs/generated/changelog.html Outdated Show resolved Hide resolved
krpeacock and others added 2 commits April 6, 2022 16:14
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
@krpeacock
Copy link
Contributor Author

There is at least one place that is still calling <agent>.addTransform(makeNonceTransform()): https://github.com/dfinity/agent-js/blob/main/demos/ledgerhq/src/main.js#L86

and a few that add a different nonce transform, but without specifying the disableNonce option. Examples:

Updated the changelog with upgrade instructions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants