Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correctly decode optional struct fields #564

Merged
merged 5 commits into from Apr 20, 2022
Merged

fix: Correctly decode optional struct fields #564

merged 5 commits into from Apr 20, 2022

Conversation

frederikrothenberger
Copy link
Member

@frederikrothenberger frederikrothenberger commented Apr 20, 2022 •
edited

Description

Fixes incorrect decoding of optional struct fields.

How Has This Been Tested?

A unit test for this corner case has been added.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Base automatically changed from frederik/retain-func-type to main April 20, 2022 19:14
@krpeacock krpeacock enabled auto-merge (squash) April 20, 2022 19:18
@krpeacock krpeacock merged commit 47ee650 into main Apr 20, 2022
@krpeacock krpeacock deleted the frederik/fix-opt-low-hash branch April 20, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krpeacock krpeacock krpeacock approved these changes

@chenyan-dfinity chenyan-dfinity Awaiting requested review from chenyan-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frederikrothenberger @krpeacock @chenyan-dfinity