feat: idlemanager reload by default #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, refreshes the page unless an alternative CB is provided during initialization or is registered after the fact
dfx-json
approved these changes
May 5, 2022
There was a problem hiding this comment.
Thanks a lot for implementing this right away @krpeacock ! I like the solution of registering also a reload on idle.
But IIUC there is a bug, see my comments below.
…into kyle/idle-reload
robin-kunzler
approved these changes
May 13, 2022
There was a problem hiding this comment.
@krpeacock : Looks great, thanks! I like the API and the test that verifies that both the storage is cleared and the reload happens. 👍 Approving the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To further enhance the IdleManager's default configuration for security, IdleManager now provides a default callback that will refresh the page, fully exiting the session.
The developer is still encouraged to register their own callback to enhance the user experience. Passing a custom callback will override the default callback
Checklist: