fix: add setBigUint64 polyfill #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfx-json
reviewed
Jun 2, 2022
There was a problem hiding this comment.
Hi @mstrasinskis. The proposed changes look good. The only thing I would like to know is how we can verify lines 118 and 119 produce a result equivalent to line 115 (types.ts)? Could you perhaps add one more test? Thank you!
|
Good point, @dfx-json. The test was replaced. Consistency of results is the only important characteristic of the polyfill. |
dfx-json
approved these changes
Jun 3, 2022
bitdivine
approved these changes
Jun 3, 2022
|
merging on behalf of @bitdivine , apparently GitHub is having a slow day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
setBigUint64polyfill because of the multiple error reports. (based on nns-dapp solution)