Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for derivationOrigin #588

Merged
merged 1 commit into from Jul 6, 2022
Merged

feat: adds support for derivationOrigin #588

merged 1 commit into from Jul 6, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jul 5, 2022 •
edited

Description

Agent-js should allow to pass on a derivation_origin during login that should be used for principal derivation (as opposed to the front-end origin)

How Has This Been Tested?

Unit test added

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested review from frederikrothenberger and a team July 5, 2022 18:00
frederikrothenberger
frederikrothenberger approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very fast change :-)

@krpeacock krpeacock merged commit c4726bd into main Jul 6, 2022
@krpeacock krpeacock deleted the SDK-576-derivationOrigin branch July 6, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krpeacock @ericswanson-dfinity @frederikrothenberger