fix: IDL edge case involving Math.log2 function on BigInt bit count #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -647,7 +648,7 @@ export class FixedIntClass extends PrimitiveType<bigint | number> { | |||
| } | |||
|
|
|||
| public encodeType() { | |||
| const offset = Math.log2(this._bits) - 3; | |||
| const offset = ilog2(this._bits) - 3; | |||
There was a problem hiding this comment.
Is this the right place for the fix? this._bits can only be 8,16,32,64. I would expect the problem comes from taking log2 of the actual number, not _bits?
|
Closing in favor of a different solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
Math.log2is sometimes called on a BigInt value in@dfinity/candid(possibly a regression from #575), causing an unexpected error in Motoko Playground.This PR adds a custom
ilog2implementation (based on this StackOverflow post) which accounts for BigInt values while providing clearer error messages when receiving invalid input.How Has This Been Tested?
ilog2functionChecklist: