Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replaces links with icp.host to xyz for nice url for docs #601

Merged
merged 2 commits into from Jul 28, 2022
Merged

chore: replaces links with icp.host to xyz for nice url for docs #601

merged 2 commits into from Jul 28, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jul 27, 2022 •
edited

Description

There's a nicer format for canister urls with icns. The docs can now avoid a redirect using https://agent-js.icp.xyz

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner July 27, 2022 17:18
@krpeacock krpeacock merged commit 8fc0b17 into main Jul 28, 2022
@krpeacock krpeacock deleted the host-to-xyz branch July 28, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @ericswanson-dfinity