fix: migration from localstorage to idb #608
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To migrate from localstorage to idb, AuthClient tries to find current values in the storage with the incorrect keys - i.e it tries to load
icdelegationandicidentityinstead ofic-delegationandic-identityand therefore, no session are found and migrated.This is because a
LocalStorageobject is initialized with the prefixicinstead ofic-.How Has This Been Tested?
I tried to bump agent-js from v0.12.0 v0.13.0 in my project cycles.watch locally and noticed that I lost my session. Then debugged and found the prefix mismatch.
Reference
This PR is a follow-up to PR #606 and release of agent-js v0.13.0 (changelog)
Open questions
All consumers used to inherits prefix
ic-or was it an option? If it was a variable that can be set by the developers, then the migration should be extended with such param as well.