fix: return after resolve to avoid idb to be recreated #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krpeacock
requested changes
Sep 6, 2022
There was a problem hiding this comment.
@peterpeterparker I've let it slide a couple times before, but could you please include edits to changelog.html with your PR's?
|
Done, added an entry in changelog.html for this PR and your last week's fix |
krpeacock
approved these changes
Sep 20, 2022
krpeacock
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While I did not actually face any issue related to this PR, based on the code, a
returnseems to be missing after promise resolution when the instance of the idb connection is requested withinIdbStorage- i.e. even though the connection exists, it might be recreated anyway.