Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Asset manager performance #639

Merged
merged 5 commits into from Oct 6, 2022
Merged

feat: Asset manager performance #639

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc426b2
Merge pull request #1 from dfinity/main
sea-snake Sep 26, 2022
3f3c4c9
Merge branch 'dfinity:main' into main
sea-snake Oct 6, 2022
7260e1a
feat: Increase file sizes in E2E assets tests.
sea-snake Oct 6, 2022
a5d05a2
Merge pull request #6 from dfinity/main
sea-snake Oct 6, 2022
4276744
Use default chunk size.
sea-snake Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions e2e/node/basic/assets.test.ts
View file
Open in desktop
Expand Up @@ -51,8 +51,6 @@ describe('assets', () => {
const assetManager = new AssetManager({
canisterId,
agent: await agent,
maxSingleFileSize: 1900,
maxChunkSize: 1900,
});
const readable = randomBytesReadable(fileName, length);
const key = await assetManager.store(readable);
Expand Down Expand Up @@ -86,9 +84,9 @@ describe('assets', () => {
}
});

it('store, get and delete 1KB asset (single chunk)', () => testRandomBytes('1KB.bin', 1000));
it('store, get and delete 1MB asset (single chunk)', () => testRandomBytes('1MB.bin', 1000000));

it('store, get and delete 3KB asset (multiple chunk)', () => testRandomBytes('3KB.bin', 3000));
it('store, get and delete 3MB asset (multiple chunk)', () => testRandomBytes('3MB.bin', 3000000));

it('batch process assets and verify asset list', async () => {
const assetManager = new AssetManager({ canisterId, agent: await agent });
Expand Down