Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds js-sha256 dependency to principal #641

Merged
merged 2 commits into from Oct 10, 2022
Merged

chore: adds js-sha256 dependency to principal #641

merged 2 commits into from Oct 10, 2022

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 10, 2022 •
edited

Description

Principal was using a package used elsewhere but was not included in its package dependencies

Fixes #522

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner October 10, 2022 21:41
@krpeacock krpeacock enabled auto-merge (squash) October 10, 2022 21:44
@krpeacock krpeacock merged commit 3ea9e67 into main Oct 10, 2022
@krpeacock krpeacock deleted the kyle/js-sha-dependency branch October 10, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanasa rvanasa rvanasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@dfinity/principal: Cannot find module 'js-sha256'
2 participants
@krpeacock @rvanasa