feat: secp256k1 fromSeedPhrase now supported #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
approved these changes
Oct 13, 2022
|
Pending security review |
There was a problem hiding this comment.
@krpeacock : Thanks a lot for adding this! As requested I reviewed the security warnings and they look good to me, thanks. Also, given those warnings it seems OK to me to provide this additional features.
Just out of curiosity: Do you know what use cases people want to solve with this?
FYI Internet Identity also has code that creates a Ed25519KeyIdentity from a seed phrase. See here.
|
|
||
| This identity can be generated using the bip39 curve from a seed phrase, to produce a consistent identity across `dfx` and `agent-js`. In this package, import `Secp256k1KeyIdentity` and call `fromSeed`, passing in your seed. You can import the same seed in `dfx` by writing it to a file, and running `dfx identity import --seed-file <filename>`. | ||
|
|
||
| Depending on the security of what this identity controls, this should not be used carelessly. Even copy/pasting a phrase can be a risk, and you should make your best efforts to discourage your users from storing seed phrases digitally or using them in browser contexts that may be at risk of cross-site scripting. |
There was a problem hiding this comment.
I like the warning, thanks for adding it!
krpeacock
commented
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some time, people have requested support for re-using a consistent identity across their stack, either for testing purposes or CI. This code has been available, but was not included in
agent-js. For convenience, this method is now supportedAffects #622
How Has This Been Tested?
Unit testing
Checklist: