Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Small edit in JS Doc comment in Auth-Client Package #657

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Web3NL
Copy link
Contributor

@Web3NL Web3NL commented Nov 22, 2022

After switch to idbStorage, comment was left unedited

@Web3NL Web3NL requested a review from a team as a code owner November 22, 2022 15:54
@dfinity-droid-prod
Copy link

Dear @Web3NL,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@dfinity-droid-prod
Copy link

Dear @Web3NL,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@Web3NL Web3NL changed the title Small edit in JS Doc comment in Auth-Client Package Fix: Small edit in JS Doc comment in Auth-Client Package Nov 22, 2022
@Web3NL Web3NL changed the title Fix: Small edit in JS Doc comment in Auth-Client Package docs: Small edit in JS Doc comment in Auth-Client Package Nov 22, 2022
@krpeacock
Copy link
Contributor

I think the CI broke with the latest SDK update. Can you merge the latest from main?

@krpeacock krpeacock enabled auto-merge (squash) December 8, 2022 19:25
@krpeacock krpeacock merged commit 4175351 into dfinity:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants