Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to secure ECDSA key for auth-client #674

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jan 4, 2023

Description

Now that we have the non-exportable ECDSAKeyIdentity using CryptoKeys, we can use it as the base key for II Delegations.

Fixes # FOLLOW-814

How Has This Been Tested?

New unit tests, also by compiling the package and using it in the auth-client-demo application

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

size-limit report 📦

Path Size
@dfinity/agent 89.89 KB (0%)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 95.46 KB (+0.53% 🔺)
@dfinity/assets 92.07 KB (0%)
@dfinity/identity 92.35 KB (0%)
@dfinity/identity-secp256k1 229.99 KB (0%)

@krpeacock krpeacock requested a review from a team January 4, 2023 23:53
@krpeacock krpeacock merged commit 196a647 into main Jan 9, 2023
@krpeacock krpeacock deleted the FOLLOW-814/ecdsa-stored-key branch January 9, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants