Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: documents fetch options #687

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 13, 2023

Description

Based on feedback from devs, adds documentation on using fetch in a Node environment, and references the fetchOptions api

Fixes SDK-988

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 13, 2023 23:17
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023

size-limit report 📦

Path Size
@dfinity/agent 89.91 KB (0%)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 95.46 KB (0%)
@dfinity/assets 92.07 KB (0%)
@dfinity/identity 92.35 KB (0%)
@dfinity/identity-secp256k1 230.01 KB (0%)

@krpeacock krpeacock merged commit ad61e5f into main Feb 13, 2023
@krpeacock krpeacock deleted the SDK-988/document-fetchOptions branch February 13, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants