Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changes default host and supports icp-api.io #690

Merged
merged 7 commits into from
Feb 21, 2023
Merged

feat: changes default host and supports icp-api.io #690

merged 7 commits into from
Feb 21, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 16, 2023 •
edited

Description

Lists icp-api.io as the default host in documentation. Also

  • adds rewrite support for subdomains the same way as ic0.app
    • for icp-api.io
    • for icp0.io

How Has This Been Tested?

New unit tests

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 16, 2023 20:42
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2023 •
edited

size-limit report 📦

Path Size
@dfinity/agent 88.85 KB (+0.06% 🔺)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 95.03 KB (0%)
@dfinity/assets 91.55 KB (0%)
@dfinity/identity 91.94 KB (0%)
@dfinity/identity-secp256k1 230.16 KB (+0.03% 🔺)

@dependabot
chore(deps): bump json5 from 2.2.1 to 2.2.3 in /e2e/browser (#676)
5ed5f20 
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@krpeacock krpeacock changed the title feat: changes default host and rewrites ic0.app calls to icp-api.io feat: changes default host supports icp-api.io Feb 21, 2023
@krpeacock krpeacock changed the title feat: changes default host supports icp-api.io feat: changes default host and supports icp-api.io Feb 21, 2023
@krpeacock krpeacock enabled auto-merge (squash) February 21, 2023 19:08
@krpeacock krpeacock merged commit 6b64030 into main Feb 21, 2023
@krpeacock krpeacock deleted the kyle/default-host branch February 21, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @dfx-json