Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverts use of Headers for improved node compatibility #694

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Feb 25, 2023

Description

Due to the use of Headers inside of Agent-JS, it introduced a nodejs compatibility issue. We can simply swap back with no impact on the functionality

Fixes #685

How Has This Been Tested?

Unit tests

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner February 25, 2023 19:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2023

size-limit report 📦

Path Size
@dfinity/agent 88.83 KB (-0.02% 🔽)
@dfinity/candid 15.46 KB (0%)
@dfinity/principal 6.77 KB (0%)
@dfinity/auth-client 95.04 KB (0%)
@dfinity/assets 91.53 KB (0%)
@dfinity/identity 92.01 KB (0%)
@dfinity/identity-secp256k1 230.14 KB (-0.01% 🔽)

Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a note in the changelog to be reverted or amended?

@krpeacock
Copy link
Contributor Author

@ericswanson-dfinity I don't think it's necessary - I'm keeping type support for someone to pass a Headers struct if they want to, but no longer using it by default in the implementation. Simply adding a note to the changelog should be adequate

@ericswanson-dfinity
Copy link
Member

Simply adding a note to the changelog should be adequate

Did you mean to include such a note in this PR?

@krpeacock krpeacock enabled auto-merge (squash) May 22, 2023 16:31
@krpeacock krpeacock requested a review from a team June 21, 2023 19:34
@krpeacock krpeacock merged commit 2a30c33 into main Jun 21, 2023
14 checks passed
@krpeacock krpeacock deleted the kyle/revert-headers branch June 21, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers is not used in nodejs env.
2 participants