Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in JsonnableWebAuthnIdentitiy #725

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Jun 18, 2023

Fix typo in JsonnableWebAuthnIdentitiy, breaking change that requires users to update their imports to JsonnableWebAuthnIdentity when this type is used.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

Fix typo in JsonnableWebAuthnIdentitiy, is a breaking change that would require users to update their imports when they use this type.
@sea-snake sea-snake requested a review from a team as a code owner June 18, 2023 15:01
@krpeacock
Copy link
Contributor

@sea-snake this isn't your fault at all, but can you move the changelog note up into the next block?

@sea-snake
Copy link
Contributor Author

sea-snake commented Jun 21, 2023

@sea-snake this isn't your fault at all, but can you move the changelog note up into the next block?

No problem, I've updated the PR :D

@krpeacock krpeacock merged commit 97ff6f8 into dfinity:main Jun 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants