fix: bigint toJson trailing space #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template literal was compiling incorrectly, causing a space to be added in the middle of the BigInt conversion, causing a throw on AuthClient.create(), causing _deleteStorage() to be called, preventing some users from being authenticated to call anything after connecting.
|
Dear @dgdg-app, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
|
Dear @dgdg-app, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
krpeacock
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template literal was compiling incorrectly, causing a space to be added in the middle of the BigInt conversion of DelegationChain.fromJson(), causing a throw on AuthClient.create(), causing _deleteStorage() to be called, preventing some users from remaining authenticated to call anything after connecting.
Description
...
Fixes # (issue)
Users not being able to make calls after an otherwise successful connect.
How Has This Been Tested?
Chrome v116, manual e2e testing found the error on connecting to stoic wallet with affected version of Chrome, the pathway of the throw explains the condition users not being able to make calls, unverified if it solves the problem but it looks like it should. Chrome v117 (beta) does not have this issue on most devices.
Checklist: