Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove deprecated packages #785

Merged
merged 2 commits into from Oct 31, 2023
Merged

Conversation

smallstepman
Copy link

Removes @dfinity/identity-ledgerhq and @dfinity/authentication from repository - both were deprecated #665 and #661

@smallstepman smallstepman requested a review from a team as a code owner October 23, 2023 13:06
@smallstepman
Copy link
Author

@krpeacock I'll need your help with regenerating packages/identity-secp256k1/package-lock.json and e2e/browser/package-lock.json - I tried but ultimately couldn't figure it out

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

size-limit report 📦

Path Size
@dfinity/agent 88.39 KB (0%)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.69 KB (0%)
@dfinity/assets 90.81 KB (0%)
@dfinity/identity 89.96 KB (0%)
@dfinity/identity-secp256k1 233.61 KB (0%)

@krpeacock
Copy link
Contributor

@smallstepman those can be removed, actually

@krpeacock krpeacock merged commit d3eb416 into main Oct 31, 2023
14 checks passed
@krpeacock krpeacock deleted the mnl/remove-deprecated-packages branch October 31, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants