Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release and publishing automation #786

Merged
merged 5 commits into from
Nov 1, 2023
Merged

ci: release and publishing automation #786

merged 5 commits into from
Nov 1, 2023

Conversation

smallstepman
Copy link

@smallstepman smallstepman commented Oct 23, 2023 •
edited

Description

This PR:

  • Reimplements the release and publishing process as described in the updated CONTRIBUTING.md file
  • Overhaul the docs cause a lot of the information was outdated. Moves info from README.md and docs/npm-publish.md and consolidates it in CONTRIBUTING.md.

Implements https://dfinity.atlassian.net/browse/SDK-1188

How Has This Been Tested?

Manually, on fork: https://github.com/smallstepman/agent-js

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@smallstepman smallstepman requested a review from a team as a code owner October 23, 2023 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited

size-limit report 📦

Path Size
@dfinity/agent 88.39 KB (0%)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.68 KB (0%)
@dfinity/assets 90.81 KB (0%)
@dfinity/identity 89.96 KB (0%)
@dfinity/identity-secp256k1 233.63 KB (0%)

@smallstepman smallstepman force-pushed the mnl/release-automation branch 3 times, most recently from a7c7758 to 352eea9 Compare October 23, 2023 16:09
krpeacock
krpeacock requested changes Oct 31, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/workflows/publish.yml Show resolved Hide resolved
krpeacock and others added 2 commits October 31, 2023 11:46
@krpeacock
Merge branch 'mnl/release-automation' of github.com:dfinity/agent-js …
959bdd9 
…into mnl/release-automation
@krpeacock
Update CONTRIBUTING.md
9482ae1 
Co-authored-by: Kyle Peacock <kylpeacock@gmail.com>
@krpeacock krpeacock merged commit bb665ce into main Nov 1, 2023
14 checks passed
@krpeacock krpeacock deleted the mnl/release-automation branch November 1, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krpeacock krpeacock krpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smallstepman @krpeacock