Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor to remove nonce from queries #792

Merged
merged 5 commits into from
Nov 1, 2023
Merged

feat: refactor to remove nonce from queries #792

merged 5 commits into from
Nov 1, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 31, 2023 •
edited

Description

replaces disableNonce feature with useQueryNonces. Going forward, calls will use nonces, but queries and readstate calls will not. Queries and readsatate calls will use nonces if useQueryNonces is set to true.

Fixes # (issue)

How Has This Been Tested?

Removes the nonceless e2e tests as they are no longer applicable

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner October 31, 2023 21:42
@krpeacock krpeacock changed the title Kyle/sdk 1258 remove nonce queries feat: refactor to remove nonce from queries Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited

size-limit report 📦

Path Size
@dfinity/agent 88.48 KB (+0.08% 🔺)
@dfinity/candid 13.59 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.7 KB (+0.02% 🔺)
@dfinity/assets 90.83 KB (+0.01% 🔺)
@dfinity/identity 89.97 KB (+0.02% 🔺)
@dfinity/identity-secp256k1 233.8 KB (+0.07% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) November 1, 2023 18:18
@ShuoWangNSL
Copy link
Collaborator

Thanks. LGTM!

@krpeacock krpeacock mentioned this pull request Nov 1, 2023
Merged
4 tasks
krpeacock and others added 2 commits November 1, 2023 14:21
@krpeacock @ericswanson-dfinity
Update docs/generated/changelog.html
c3b36eb 
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
@krpeacock
changing call to update for clarity
0935bae
@krpeacock krpeacock merged commit 6e7b142 into main Nov 1, 2023
14 checks passed
@krpeacock krpeacock deleted the kyle/SDK-1258-remove-nonce-queries branch November 1, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@ShuoWangNSL ShuoWangNSL Awaiting requested review from ShuoWangNSL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krpeacock @ShuoWangNSL @ericswanson-dfinity