Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: canisterStatus returns full list of controllers #799

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: canisterStatus returns full list of controllers #799

merged 3 commits into from
Nov 13, 2023

Conversation

krpeacock
Copy link
Contributor

Description

We had a bug noted where not all controllers were being reported. This fixes the issue and adds tests against mainnet

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner November 13, 2023 19:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited

size-limit report 📦

Path Size
@dfinity/agent 98.17 KB (-0.02% 🔽)
@dfinity/candid 13.41 KB (0%)
@dfinity/principal 5.01 KB (0%)
@dfinity/auth-client 90.53 KB (0%)
@dfinity/assets 91.07 KB (0%)
@dfinity/identity 88.01 KB (0%)
@dfinity/identity-secp256k1 249.4 KB (-0.01% 🔽)

@krpeacock krpeacock merged commit 2ddecf6 into main Nov 13, 2023
14 checks passed
@krpeacock krpeacock deleted the kyle/SDK-1287-missing-controllers branch November 13, 2023 21:44
@krpeacock krpeacock mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krpeacock @dfx-json