Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restoring localhost to list of known hosts #805

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Nov 27, 2023

Description

It's unclear where this regression began, but obviously localhost should have been in the list instead of a duplicated 127.0.0.1. Resolves the mysterious subnet_not_found error from local development while using localhost domain

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner November 27, 2023 17:34
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/agent 98.58 KB (+0.01% 🔺)
@dfinity/candid 13.41 KB (0%)
@dfinity/principal 5.01 KB (0%)
@dfinity/auth-client 90.58 KB (0%)
@dfinity/assets 91.11 KB (0%)
@dfinity/identity 88.06 KB (0%)
@dfinity/identity-secp256k1 254.38 KB (+0.01% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) November 27, 2023 17:40
@krpeacock krpeacock merged commit 3394380 into main Nov 27, 2023
60 checks passed
@krpeacock krpeacock deleted the kyle/localhost-known-host branch November 27, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants