Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent dependency version #301

Closed
wants to merge 1 commit into from
Closed

Update agent dependency version #301

wants to merge 1 commit into from

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Mar 6, 2023

Motivation

Agent js 0.15.4 removed some circular dependencies (dfinity/agent-js#688, dfinity/agent-js#691) which makes nns-dapp less likely to hit rollup/plugins#1425 and more reproducible as a result.

Changes

npm rm @dfinity/agent @dfinity/candid @dfinity/principal @dfinity/utils  --workspace=packages/ckbtc
npm i @dfinity/agent @dfinity/candid @dfinity/principal @dfinity/utils --save-peer   --workspace=packages/ckbtc
npm rm @dfinity/agent @dfinity/candid @dfinity/principal @dfinity/utils  --workspace=packages/cmc
npm i @dfinity/agent @dfinity/candid @dfinity/principal @dfinity/utils --save-peer   --workspace=packages/cmc
npm rm @dfinity/{agent,candid,principal,utils}  --workspace=packages/ledger
npm i @dfinity/{agent,candid,principal,utils} --save-peer   --workspace=packages/ledger
npm rm @dfinity/{agent,candid,principal,utils}  --workspace=packages/nns
npm i @dfinity/{agent,candid,principal,utils} --save-peer   --workspace=packages/nns
npm rm @dfinity/{agent,candid,ledger,principal,utils}  --workspace=packages/sns
npm i @dfinity/{agent,candid,ledger,principal,utils} --save-peer   --workspace=packages/sns
npm rm @dfinity/{agent,candid,principal}  --workspace=packages/utils
npm i @dfinity/{agent,candid,principal} --save-peer   --workspace=packages/utils

Tests

npm ci
npm run test

@peterpeterparker
Copy link
Member

Duplicate #302 therefore allow my self to close it. If I should have not, of course please do reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants