New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with vitejs #1417
Build with vitejs #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seems to be an issue here, images are gone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks having a look
src/showcase/.eslintrc.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for vite? why did all the showcase files have to move btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this for vite?
this what?
why did all the showcase files have to move btw?
vite needs one single entry, an index.html
. did not really found how to have index.html
and showcase.html
and having it separate is cleaner anyway.
HACKING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why all list items changed from *
to -
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier format
Maybe this is a stupid question, but doesn't |
That's a good point, we have to test. In NNS-dapp the recent reproducibility issues had to do with packaging CSS, which has been solved in Rollup and is probably not a problem for II because the CSS is not chunked, and some recursive import on library packaged within the ledgerhq hardware wallet which we do not have neither here. But yeah few tests is a good idea. |
First reproducibility issue did not work so I'm trying now the option discussed in rollup/plugins#1425 (comment) |
Reproducibility issue solved and tested @frederikrothenberger. There was one issue discovered by @nmattia (💪). Rollup does not generate |
Let's have a clean start. I created a patch from this PR and started a new clean one 👉 #1461 |
Changes
webpack
forvite
vite.config.ts
script
or prerendering - tovite.plugin.ts
html
file forindex.html
showcase
html and ts file to separate directorybuffer
,process
andstream-browserify
as dependencies instead of dev dependencies because these are suchbuffer
manually inindex.ts
module
by canisterRemaining non-production blocker tasks in #1458.