Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compatibility for ic-agent #6

Merged
merged 3 commits into from Jul 25, 2022
Merged

feat: compatibility for ic-agent #6

merged 3 commits into from Jul 25, 2022

Conversation

Daniel-Bloom-dfinity
Copy link
Contributor

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity commented Jul 5, 2022 •
edited

Companion to dfinity/agent-js#590

This should now be compatible with agent-rs and agent-js. This includes preparing Cargo.toml for wasm-pack.

Also fixes-up the std feature (e.g. conditionally enable no_std).

Adds in the test from ic-agent to verify compatibility.

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity mentioned this pull request Jul 7, 2022
Merged
4 tasks
@blynn blynn merged commit 9b48ab9 into dfinity:main Jul 25, 2022
@Daniel-Bloom-dfinity Daniel-Bloom-dfinity deleted the dbloom/agent-rs branch July 29, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Daniel-Bloom-dfinity @chenyan-dfinity @blynn