Skip to content

Commit

Permalink
style: redo scoped styles (#1671)
Browse files Browse the repository at this point in the history
# Motivation

In #1666 we have moved scoped styles to global style to workaround the build reproducibility of SvelteKit+ViteJS [#8291](sveltejs/kit#8291).

This PR redo the changes has #1670 will solve the reproducibility issue by removing the unused vite manifest file from our build results.

# PRs

- [x] #1670

# Changes

- redo scoped style and remove related global style
  • Loading branch information
peterpeterparker committed Jan 16, 2023
1 parent 0c21349 commit bf6df91
Show file tree
Hide file tree
Showing 5 changed files with 42 additions and 16 deletions.
15 changes: 14 additions & 1 deletion frontend/src/lib/pages/SignInAccounts.svelte
Expand Up @@ -5,7 +5,7 @@
// TODO(GIX-1071): this static pre-rendering component should be improved with some more information and shiny design
</script>

<main class="sign-in">
<main>
<h1>{$i18n.auth_accounts.title}</h1>

<p>
Expand All @@ -14,3 +14,16 @@

<SignIn />
</main>

<style lang="scss">
main {
display: flex;
flex-direction: column;
}
h1 {
line-height: var(--line-height-standard);
}
p {
margin-bottom: var(--padding-3x);
}
</style>
15 changes: 14 additions & 1 deletion frontend/src/lib/pages/SignInCanisters.svelte
Expand Up @@ -5,7 +5,7 @@
// TODO(GIX-1071): this static pre-rendering component should be improved with some more information and shiny design
</script>

<main class="sign-in">
<main>
<h1>{$i18n.auth_canisters.title}</h1>

<p>
Expand All @@ -14,3 +14,16 @@

<SignIn />
</main>

<style lang="scss">
main {
display: flex;
flex-direction: column;
}
h1 {
line-height: var(--line-height-standard);
}
p {
margin-bottom: var(--padding-3x);
}
</style>
15 changes: 14 additions & 1 deletion frontend/src/lib/pages/SignInNeurons.svelte
Expand Up @@ -5,7 +5,7 @@
// TODO(GIX-1071): this static pre-rendering component should be improved with some more information and shiny design
</script>

<main class="sign-in">
<main>
<h1>{$i18n.auth_neurons.title}</h1>

<p>
Expand All @@ -14,3 +14,16 @@

<SignIn />
</main>

<style lang="scss">
main {
display: flex;
flex-direction: column;
}
h1 {
line-height: var(--line-height-standard);
}
p {
margin-bottom: var(--padding-3x);
}
</style>
12 changes: 0 additions & 12 deletions frontend/src/lib/themes/global.scss

This file was deleted.

1 change: 0 additions & 1 deletion frontend/src/routes/+layout.svelte
Expand Up @@ -50,6 +50,5 @@
<style lang="scss" global>
@import "@dfinity/gix-components/styles/global.scss";
@import "../lib/themes/legacy";
@import "../lib/themes/global";
@import "../lib/themes/variables";
</style>

0 comments on commit bf6df91

Please sign in to comment.