Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Long story short: on iOS, click on the "Login" have no effect 馃憠 user cannot sign-in on iOS with the current development version which uses agent-js
v0.13.x
(mainnet uses currentlyv0.12.x
which is fine).More details and context in related agent-js issue dfinity/agent-js#618
Changes
authClient
object in memory to not callauthClient.create
beforeauthClient.login
- i.e. avoid any async callback within the same function that should ultimately callwindow.open