Skip to content

Commit

Permalink
chore: upgrade prometheus dependency to 1.14
Browse files Browse the repository at this point in the history
This removes the metric `go_memstats_gc_cpu_fraction`.
This metric is not useful and often misleading due to the
fact that it's an average over the lifetime of the process.
See prometheus/client_golang#842 (comment)

These are the new metrics that are added:

go_cgo_go_to_c_calls_calls_total
go_cpu_classes_gc_mark_assist_cpu_seconds_total
go_cpu_classes_gc_mark_dedicated_cpu_seconds_total
go_cpu_classes_gc_mark_idle_cpu_seconds_total
go_cpu_classes_gc_pause_cpu_seconds_total
go_cpu_classes_gc_total_cpu_seconds_total
go_cpu_classes_idle_cpu_seconds_total
go_cpu_classes_scavenge_assist_cpu_seconds_total
go_cpu_classes_scavenge_background_cpu_seconds_total
go_cpu_classes_scavenge_total_cpu_seconds_total
go_cpu_classes_total_cpu_seconds_total
go_cpu_classes_user_cpu_seconds_total
go_gc_cycles_automatic_gc_cycles_total
go_gc_cycles_forced_gc_cycles_total
go_gc_cycles_total_gc_cycles_total

go_gc_heap_allocs_by_size_bytes_bucket
go_gc_heap_allocs_by_size_bytes_count
go_gc_heap_allocs_by_size_bytes_sum
go_gc_heap_allocs_bytes_total
go_gc_heap_allocs_objects_total
go_gc_heap_frees_by_size_bytes_bucket
go_gc_heap_frees_by_size_bytes_count
go_gc_heap_frees_by_size_bytes_sum
go_gc_heap_frees_bytes_total
go_gc_heap_frees_objects_total
go_gc_heap_goal_bytes
go_gc_heap_objects_objects
go_gc_heap_tiny_allocs_objects_total
go_gc_limiter_last_enabled_gc_cycle
go_gc_pauses_seconds_bucket
go_gc_pauses_seconds_count
go_gc_pauses_seconds_sum
go_gc_stack_starting_size_bytes

go_memory_classes_heap_free_bytes
go_memory_classes_heap_objects_bytes
go_memory_classes_heap_released_bytes
go_memory_classes_heap_stacks_bytes
go_memory_classes_heap_unused_bytes
go_memory_classes_metadata_mcache_free_bytes
go_memory_classes_metadata_mcache_inuse_bytes
go_memory_classes_metadata_mspan_free_bytes
go_memory_classes_metadata_mspan_inuse_bytes
go_memory_classes_metadata_other_bytes
go_memory_classes_os_stacks_bytes
go_memory_classes_other_bytes
go_memory_classes_profiling_buckets_bytes
go_memory_classes_total_bytes

go_sched_gomaxprocs_threads
go_sched_goroutines_goroutines
go_sched_latencies_seconds_bucket
go_sched_latencies_seconds_count
go_sched_latencies_seconds_sum
go_sync_mutex_wait_total_seconds_total
  • Loading branch information
joshua-goldstein authored and mangalaman93 committed Feb 9, 2023
1 parent 3c100d5 commit f868a33
Show file tree
Hide file tree
Showing 4 changed files with 260 additions and 57 deletions.
2 changes: 1 addition & 1 deletion dgraph/cmd/alpha/metrics_test.go
Expand Up @@ -176,7 +176,7 @@ func TestMetrics(t *testing.T) {

requiredMetrics := []string{
// Go Runtime Metrics
"go_goroutines", "go_memstats_gc_cpu_fraction", "go_memstats_heap_alloc_bytes",
"go_goroutines", "go_memstats_heap_alloc_bytes",
"go_memstats_heap_idle_bytes", "go_memstats_heap_inuse_bytes", "dgraph_latency_bucket",

// Badger Metrics
Expand Down
44 changes: 22 additions & 22 deletions go.mod
Expand Up @@ -31,8 +31,8 @@ require (
github.com/golang/protobuf v1.5.2
github.com/golang/snappy v0.0.3
github.com/google/codesearch v1.0.0
github.com/google/go-cmp v0.5.5
github.com/google/uuid v1.0.0
github.com/google/go-cmp v0.5.9
github.com/google/uuid v1.3.0
github.com/gorilla/websocket v1.4.2
github.com/graph-gophers/graphql-go v0.0.0-20200309224638-dae41bde9ef9
github.com/hashicorp/vault/api v1.0.4
Expand All @@ -41,7 +41,7 @@ require (
github.com/paulmach/go.geojson v0.0.0-20170327170536-40612a87147b
github.com/pkg/errors v0.9.1
github.com/pkg/profile v1.2.1
github.com/prometheus/client_golang v1.11.1
github.com/prometheus/client_golang v1.14.0
github.com/soheilhy/cmux v0.1.4
github.com/spf13/cast v1.3.0
github.com/spf13/cobra v0.0.5
Expand All @@ -54,14 +54,14 @@ require (
go.opencensus.io v0.22.5
go.uber.org/zap v1.16.0
golang.org/x/crypto v0.0.0-20220314234659-1baeb1ce4c0b
golang.org/x/net v0.4.0
golang.org/x/net v0.5.0
golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4
golang.org/x/sys v0.3.0
golang.org/x/text v0.5.0
golang.org/x/sys v0.4.0
golang.org/x/text v0.6.0
golang.org/x/tools v0.1.12
google.golang.org/grpc v1.27.0
google.golang.org/grpc v1.52.0
gopkg.in/square/go-jose.v2 v2.3.1
gopkg.in/yaml.v2 v2.3.0
gopkg.in/yaml.v2 v2.4.0
src.techknowlogick.com/xgo v1.4.1-0.20210311222705-d25c33fcd864
)

Expand All @@ -76,7 +76,7 @@ require (
github.com/blevesearch/segment v0.9.0 // indirect
github.com/blevesearch/snowballstem v0.9.0 // indirect
github.com/cespare/xxhash v1.1.0 // indirect
github.com/cespare/xxhash/v2 v2.1.1 // indirect
github.com/cespare/xxhash/v2 v2.2.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/docker/distribution v2.8.0+incompatible // indirect
github.com/docker/go-connections v0.4.0 // indirect
Expand All @@ -85,7 +85,7 @@ require (
github.com/eapache/go-xerial-snappy v0.0.0-20180814174437-776d5712da21 // indirect
github.com/eapache/queue v1.1.0 // indirect
github.com/fsnotify/fsnotify v1.4.7 // indirect
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6 // indirect
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect
github.com/google/flatbuffers v1.12.1 // indirect
github.com/graph-gophers/graphql-transport-ws v0.0.2 // indirect
github.com/hashicorp/errwrap v1.0.0 // indirect
Expand All @@ -99,7 +99,7 @@ require (
github.com/hashicorp/vault/sdk v0.1.13 // indirect
github.com/inconshreveable/mousetrap v1.0.0 // indirect
github.com/jcmturner/gofork v1.0.0 // indirect
github.com/json-iterator/go v1.1.11 // indirect
github.com/json-iterator/go v1.1.12 // indirect
github.com/klauspost/compress v1.12.3 // indirect
github.com/klauspost/cpuid/v2 v2.0.3 // indirect
github.com/magiconair/properties v1.8.1 // indirect
Expand All @@ -108,16 +108,16 @@ require (
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/mitchellh/mapstructure v1.1.2 // indirect
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
github.com/modern-go/reflect2 v1.0.1 // indirect
github.com/modern-go/reflect2 v1.0.2 // indirect
github.com/opencontainers/go-digest v1.0.0-rc1 // indirect
github.com/opentracing/opentracing-go v1.1.0 // indirect
github.com/pelletier/go-toml v1.2.0 // indirect
github.com/philhofer/fwd v1.0.0 // indirect
github.com/pierrec/lz4 v2.6.0+incompatible // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/prometheus/client_model v0.2.0 // indirect
github.com/prometheus/common v0.26.0 // indirect
github.com/prometheus/procfs v0.6.0 // indirect
github.com/prometheus/client_model v0.3.0 // indirect
github.com/prometheus/common v0.37.0 // indirect
github.com/prometheus/procfs v0.8.0 // indirect
github.com/rcrowley/go-metrics v0.0.0-20200313005456-10cdbea86bc0 // indirect
github.com/ryanuber/go-glob v1.0.0 // indirect
github.com/spf13/afero v1.1.2 // indirect
Expand All @@ -129,13 +129,13 @@ require (
go.uber.org/atomic v1.6.0 // indirect
go.uber.org/multierr v1.5.0 // indirect
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
golang.org/x/term v0.3.0 // indirect
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 // indirect
golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
google.golang.org/api v0.13.0 // indirect
google.golang.org/appengine v1.6.1 // indirect
google.golang.org/genproto v0.0.0-20200526211855-cb27e3aa2013 // indirect
google.golang.org/protobuf v1.26.0 // indirect
golang.org/x/term v0.4.0 // indirect
golang.org/x/time v0.0.0-20191024005414-555d28b269f0 // indirect
google.golang.org/api v0.30.0 // indirect
google.golang.org/appengine v1.6.7 // indirect
google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f // indirect
google.golang.org/grpc/examples v0.0.0-20230208210314-e9d9bd0436ee // indirect
google.golang.org/protobuf v1.28.1 // indirect
gopkg.in/DataDog/dd-trace-go.v1 v1.13.1 // indirect
gopkg.in/ini.v1 v1.51.0 // indirect
gopkg.in/jcmturner/aescts.v1 v1.0.1 // indirect
Expand Down

0 comments on commit f868a33

Please sign in to comment.