Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance for get shards index #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linger1216
Copy link

@linger1216 linger1216 commented Mar 24, 2020

because numShards is power of two, so can use & operator for performance


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Mar 24, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@linger1216
Copy link
Author

linger1216 commented Mar 24, 2020

merging is blocked , reason is

Function call made to an unsafe package
Found in z/bbloom.go and z/rtutil.go

It has nothing to do with this merge
 

@jarifibrahim
Copy link
Contributor

Hey @linger1216 , the PR doesn't have benchmarks to support the performance improvement claim. Could you please point me to some references about % and & operator performance? A quick google search didn't give me anything useful.

Also, the merging is blocked because you haven't signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants