Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make policy an interface #295

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tushar-zomato
Copy link

add option to always admit new items

add option to always admit new items
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joshua-goldstein
Copy link
Contributor

There is the option of setting MaxCost and NumCounters to be very large values, so that the cache will admit essentially all items (except those dropped in the buffers). You might also be able to add items with the cost of each item to be 0. These are much easier solutions than adding an entirely new policy.

@dgraph-io dgraph-io deleted a comment from joshua-goldstein Jul 2, 2023
@@ -14,4 +14,4 @@ enabled = true


[analyzers.meta]
import_path = 'github.com/dgraph-io/ristretto'
import_path = 'github.com/tushar-zomato/ristretto'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this renaming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants