Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset all arrays at once #305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

falsandtru
Copy link

Decrease the latency on reset.

Problem

The current implementation iterates arrays for each array.

Solution

Iterate all arrays at once.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@falsandtru
Copy link
Author

CLAassistant requires excessive permissions.

Gists
Read and write access
Organizations and teams
Read-only access
Commit statuses
Read and write access
Repository webhooks and services
Read and write access

@joshua-goldstein
Copy link
Contributor

Hi @falsandtru , is there a benchmark that shows the performance gain when iterating in this way?

@falsandtru
Copy link
Author

I don't know how to benchmark the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants