Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthcheck #2047

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add healthcheck #2047

wants to merge 3 commits into from

Conversation

llaumgui
Copy link

This PR add wget in image to allow a healthcheck feature on Docker.

Add healthcheck feature on Docker image.
@dgtlmoon
Copy link
Owner

hi, did something happen? can you paste the logs of how the application crashed initially?

@llaumgui
Copy link
Author

hi, did something happen? can you paste the logs of how the application crashed initially?

No crash, it's only to monitore the docker container with the docker's healthcheck feature.

@dgtlmoon
Copy link
Owner

ok, is it possible you can use curl instead? many OS's/dists/docker bases already have curl, so it might be nicer than wget

@dgtlmoon
Copy link
Owner

tries=1 is also far too low

@llaumgui
Copy link
Author

is it possible you can use curl instead?

Done.

many OS's/dists/docker bases already have curl

Currently not in standalone with your debian version. I use apt for it.

tries=1 is also far too low

It's a wget feature. But the retry is on the healthcheck feature: https://docs.docker.com/engine/reference/builder/#healthcheck 3 retry by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants